Re: [PATCH 08/16] winegstreamer: Implement media source on gstreamer.

[Zebediah Figura]

On 3/25/20 7:12 PM, Derek Lesho wrote:
> Signed-off-by: Derek Lesho
>
> dlls/mfplat/tests/mfplat.c        |   11 +-
>   dlls/winegstreamer/gst_cbs.c      |  125 +++
>   dlls/winegstreamer/gst_cbs.h      |   33 +-
>   dlls/winegstreamer/media_source.c | 1201 ++++++++++++++++++++++++++++-
>   4 files changed, 1349 insertions(+), 21 deletions(-)

This is a huge amount of code in one patch, and subsequently difficult 
to review.

If you're having trouble splitting it, I'd suggest implementing 
IMFMediaSource functions one at a time, and e.g. handling GStreamer 
events one at a time. Individual discretion is advised, of course.