Re: [PATCH v6 1/6] robocopy: Add stub

[Florian Eder]

Hey all,
I *really* don't wanna nag, but are there any issues with these patches
that prevent them from being committed to the codebase?
If that's the case, please feel absolutely free to tell me. :-)

Sorry and kind regards, Florian

Am Di., 21. Sept. 2021 um 16:55 Uhr schrieb Florian Eder <
[e-mail]>:
> Basic files and required changes to configure(.ac) to create a stub version
> of the robocopy utility
> Signed-off-by: Florian Eder
> v6: Identical to patch in v5
>
> configure                     |  2 +-
>  configure.ac                  |  1 +
>  programs/robocopy/Makefile.in |  8 ++++++++
>  programs/robocopy/main.c      | 29 +++++++++++++++++++++++++++++
>  programs/robocopy/robocopy.rc | 34 ++++++++++++++++++++++++++++++++++
>  5 files changed, 73 insertions(+), 1 deletion(-)
>  create mode 100644 programs/robocopy/Makefile.in
>  create mode 100644 programs/robocopy/main.c
>  create mode 100644 programs/robocopy/robocopy.rc
>
> diff --git a/configure b/configure
> index db592f0868d..3a8dee81bbc 100755
> --- a/configure
> +++ b/configure
> @@ -21235,6 +21235,7 @@ wine_fn_config_makefile programs/regedit/tests
> enable_tests
>  wine_fn_config_makefile programs/regini enable_regini
>  wine_fn_config_makefile programs/regsvcs enable_regsvcs
>  wine_fn_config_makefile programs/regsvr32 enable_regsvr32
> +wine_fn_config_makefile programs/robocopy enable_robocopy
>  wine_fn_config_makefile programs/rpcss enable_rpcss
>  wine_fn_config_makefile programs/rundll.exe16 enable_win16
>  wine_fn_config_makefile programs/rundll32 enable_rundll32
> @@ -22768,4 +22769,3 @@ IFS="$ac_save_IFS"
>  $as_echo "
>  $as_me: Finished.  Do '${ac_make}' to compile Wine.
>  " >&6
> -
>
> diff --git a/configure.ac b/configure.ac
> index 0bc46a1427b..5bd54cfbba7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3959,6 +3959,7 @@ WINE_CONFIG_MAKEFILE(programs/regedit/tests)
>  WINE_CONFIG_MAKEFILE(programs/regini)
>  WINE_CONFIG_MAKEFILE(programs/regsvcs)
>  WINE_CONFIG_MAKEFILE(programs/regsvr32)
> +WINE_CONFIG_MAKEFILE(programs/robocopy)
>  WINE_CONFIG_MAKEFILE(programs/rpcss)
>  WINE_CONFIG_MAKEFILE(programs/rundll.exe16,enable_win16)
>  WINE_CONFIG_MAKEFILE(programs/rundll32)
> diff --git a/programs/robocopy/Makefile.in b/programs/robocopy/Makefile.in
> new file mode 100644
> index 00000000000..5a48be3725b
> --- /dev/null
> +++ b/programs/robocopy/Makefile.in
> @@ -0,0 +1,8 @@
> +MODULE    = robocopy.exe
> -
>
> +EXTRADLLFLAGS = -mconsole -municode -mno-cygwin
> -
>
> +C_SRCS = \
> -
>   main.c
> -
>
> +RC_SRCS = robocopy.rc
> diff --git a/programs/robocopy/main.c b/programs/robocopy/main.c
> new file mode 100644
> index 00000000000..bbda15f573a
> --- /dev/null
> +++ b/programs/robocopy/main.c
> @@ -0,0 +1,29 @@
> +/*
> -
> - Copyright 2021 Florian Eder
> -
> -
> -
> - This library is free software; you can redistribute it and/or
> -
> - modify it under the terms of the GNU Lesser General Public
> -
> - License as published by the Free Software Foundation; either
> -
> - version 2.1 of the License, or (at your option) any later version.
> -
> -
> -
> - This library is distributed in the hope that it will be useful,
> -
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> -
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -
> - Lesser General Public License for more details.
> -
> -
> -
> - You should have received a copy of the GNU Lesser General Public
> -
> - License along with this library; if not, write to the Free Software
> -
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
>
> USA
> - */
> -
>
> +#include "wine/debug.h"
> +WINE_DEFAULT_DEBUG_CHANNEL(robocopy);
> -
>
> +#define WIN32_LEAN_AND_MEAN
> +#include <windows.h>
> -
>
> +int __cdecl wmain(int argc, WCHAR *argv[])
> +{
> - WINE_FIXME("robocopy stub");
> - return 1;
>
> +}
> diff --git a/programs/robocopy/robocopy.rc b/programs/robocopy/robocopy.rc
> new file mode 100644
> index 00000000000..edae5b71d86
> --- /dev/null
> +++ b/programs/robocopy/robocopy.rc
> @@ -0,0 +1,34 @@
> +/*
> -
> - Copyright 2021 Florian Eder
> -
> -
> -
> - This library is free software; you can redistribute it and/or
> -
> - modify it under the terms of the GNU Lesser General Public
> -
> - License as published by the Free Software Foundation; either
> -
> - version 2.1 of the License, or (at your option) any later version.
> -
> -
> -
> - This library is distributed in the hope that it will be useful,
> -
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> -
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -
> - Lesser General Public License for more details.
> -
> -
> -
> - You should have received a copy of the GNU Lesser General Public
> -
> - License along with this library; if not, write to the Free Software
> -
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
>
> USA
> - */
> -
>
> +#include <windef.h>
> -
>
> +#pragma makedep po
> -
>
> +LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
> -
>
> +#define WINE_FILEDESCRIPTION_STR "Wine Robocopy"
> +#define WINE_FILENAME_STR "robocopy.exe"
> +#define WINE_FILETYPE VFT_APP
> +#define WINE_FILEVERSION 5,1,10,1027
> +#define WINE_FILEVERSION_STR "5.1.10.1027"
> -
>
> +#define WINE_PRODUCTVERSION 5,1,10,1027
> +#define WINE_PRODUCTVERSION_STR "XP027"
> -
> +#include "wine/wine_common_ver.rc"
>
> 2.32.0