On Feb 26, 2016, at 3:48 PM, Matteo Bruni matteo.mystral@gmail.com wrote:
2016-02-26 10:42 GMT+01:00 Charles Davis cdavis5x@gmail.com:
On Thu, Feb 25, 2016 at 7:29 AM, Matteo Bruni matteo.mystral@gmail.com wrote:
That seems suspicious... AFAICS the comment right above this hunk is still valid (it is for current Nvidia drivers on Win7 at least), which probably means that this patch is not a good idea.
Yeah, I was afraid of that.
Truth be told, I don't need this for an application. Besides the fact that OpenGL 3.0+ is supposed to allow this, I added it because I thought it might be useful for wined3d […]. In any case, I'd imagine from your comment that you disagree. If you do, I'll retract this patch and revert the patch adding this to winemac.drv, since no known apps depend on this.
[…]
About the related winemac.drv patch, I guess it would be better to revert it, yes. Sorry that I didn't realize about its implications earlier. We could in principle change the test with some kind of "todo_wine_if" shenanigans instead but that doesn't seem preferable.
So the reasons to revert are: a) we don't have a real test case, and b) leaving it in causes a success-in-todo_wine test failure specific to the Mac? Seem somewhat tenuous reasons to revert a change that implements functionality from the spec.
*shrugs*
I guess I don't feel strongly either way. Chip, it's up to you.
-Ken