On Sat, Dec 7, 2019 at 7:23 PM Connor McAdams conmanx360@gmail.com wrote:
Patch series to implement the functions that are used by steam big picture mode. Submitting for feedback/ideas on how to improve/change things.
Connor McAdams (10): d3d10: Allocate buffers for effect interface local_buffers. d3d10: Implement scalar effect variable set methods. d3d10: Implement scalar effect variable get methods. d3d10: Implement vector effect variable set methods. d3d10: Implement vector effect variable get methods. d3d10: Implement matrix effect variable set methods. d3d10: Implement matrix effect variable get methods. d3d10: Implement ShaderResource effect variable set method. d3d10: Get resources used by effect shaders. d3d10: Apply shader resources for shaders used in pass.
dlls/d3d10/d3d10_private.h | 28 ++ dlls/d3d10/effect.c | 758 +++++++++++++++++++++++++++++++++---- 2 files changed, 718 insertions(+), 68 deletions(-)
First of all, sorry for replying so late, I kept deferring this review for various (none of them particularly good) reasons :/
I think this patch series looks pretty good. I'm okay with the general structure and I only have mostly minor comments (which I'm going to list by replying to the individual patches). I think you can update and resend now that Wine 5.0 is out. Probably better if in chunks of ~5 patches per day at most, as usual.