Re: [PATCH v2] user32:Fix z order error when child window want to be topmost windows

[Zhiyi Zhang]

Please use your real name when submitting patches and read https://wiki.winehq.org/SubmittingPatches
> +if (!is_wine) /* FIXME: remove once Wine is fixed */
> - check_z_order(hwnd_A, 0, hwnd_B, 0, TRUE);

There is a todo_wine macro for this. You should first add the tests containing todo_wines
and add a following patch to fix the bug and remove the todo_wine.

There are also some styling issues with this patch. Please use a similar style of the surrounding code.

And is this for a specific application?

Thanks,
Zhiyi

On 2020/6/2 10:02, [e-mail] wrote:
> when set_window_pos the second param is HWND_TOPMOST,
> window with WS_CHILD do not change z order.
> Signed-off-by: cuijiajin 
>
> dlls/user32/tests/win.c | 88 +++++++++++++++++++++++++++++++++++++++++
>  dlls/user32/winpos.c    |  6 +++
>  2 files changed, 94 insertions(+)