On 07/24/17 07:40, Alex Henrie wrote:
The errno behavior is not relevant to the bugs I was trying to fix; it was just something that I thought I could fix quickly and easily. Do you think that it is worthwhile for me to continue working on it?
I think that there's more value in fixing bugs that lets application run. On the other hand this code can use some cleanup. I'm just not sure how to review code that doesn't fix any real application, changes function behavior to be compatible with newer version of the dll while making it less compatible with older versions. I was hoping that there might be a solution that will preserve compatibility with older versions and improve compatibility with newer ones (not necessarily setting errno/calling _matherr in the same way as native does for all versions of the dll).
If you're going to change most of this functions it's worth adding proper support for matherr function.
Thanks, Piotr