Re: [PATCH v2 2/2] dlls/d3d9: Fix handling of D3DENUM_WHQL_LEVEL

[Henri Verbeet]

On Fri, 11 Dec 2020 at 01:09, Rafał Harabień  wrote:
> diff --git a/dlls/d3d8/directx.c b/dlls/d3d8/directx.c
> index 0c0f2ecaadc..900e2782353 100644
> --- a/dlls/d3d8/directx.c
> +++ b/dlls/d3d8/directx.c
> @@ -121,6 +121,11 @@ static HRESULT WINAPI d3d8_GetAdapterIdentifier(IDirect3D8 *iface, UINT adapter,
>      adapter_id.description = identifier->Description;
>      adapter_id.description_size = sizeof(identifier->Description);
> - if (flags & D3DENUM_NO_WHQL_LEVEL)
> -
>    flags = flags & ~D3DENUM_NO_WHQL_LEVEL;
> - else
> -
>    flags |= WINED3DENUM_WHQL_LEVEL;
> -

That's reasonable enough, although "flags ^= WINED3DENUM_WHQL_LEVEL"
would perhaps be more straightforward.

You seem to have missed ddraw7_GetDeviceIdentifier() however, which
also uses wined3d_adapter_get_identifier().