On Wed, 24 Aug 2011, Hans Leidekker wrote:
On Wed, 2011-08-24 at 03:26 -0500, Austin English wrote:
Shouldn't that be a win_skip()? Wine always runs as administrator, and if the process is running as a limited user, something may be broken? Unless you're preparing for when wine supports non-admin mode.. :)
No, win_skip is for behavior observed on Windows that Wine should not emulate, which is not the case here. And testing if a process is correctly limited should be done elsewhere.
My understanding is that win_skip() is for tests that it's ok to skip on Windows but not ok to skip in Wine. I don't think there's more semantics attached to it than that.
From my understanding, in this case using a simple skip() means that
anyone running WineTest on Windows in a non-administrator account will get a test failure. Since we don't seem to have a policy mandating that WineTest be run in an administrator account that seems wrong and thus a win_skip() seems in order.
See also my email about best practices for running WineTest for a chance at changing/setting WineTest policy: http://www.winehq.org/pipermail/wine-devel/2011-August/091703.html