On Thu, Sep 27, 2018 at 5:04 PM, Alexandre Julliard julliard@winehq.org wrote:
If it's necessary to make things easier to understand, yes. That doesn't seem to be the case here.
The important resource here is not a few bytes of memory or a couple of CPU cycles, it's developer's time. Making unnecessary changes has a cost in brain cycles, when reviewing the patch, when searching through the history, and when trying to understand why things are done a certain way. Please keep that in mind.
-- Alexandre Julliard julliard@winehq.org
Yes in those situations, but I think this patch is pretty harmless as it is, it doesn't make it harder to understand, just moving around 1 member and using bitfield for flags. The new field would have to be added anyway. I guess the original rejected form with BOOLEAN instead of BOOL would have been less changes.
But anyway please consider it, so that the rest of the patches in this series can also be committed, then I can send the IACList::Expand patch series and finally finish the original series this is all based from for now... and move on to the redesign of the enumeration (to finish two of the TODO at the top of the file)