Re: [PATCH 3/3] msxml3: Return URL from get_namespaceURI from attributes for MSXML6.

[Nikolay Sivov]

On 08/26/2018 07:27 PM, Daniel Lehman wrote:
> static const xmlChar xmlns[] = "xmlns";
> +static const xmlChar xmlnsURI[] ="http://www.w3.org/2000/xmlns/";
>
> typedef struct _domattr
>   {
> @@ -559,7 +560,12 @@ static HRESULT WINAPI domattr_get_namespaceURI(
>           if (xmlStrEqual(This->node.node->name, xmlns))
>               *p = bstr_from_xmlChar(xmlns);
>           else if (xmlStrEqual(ns->prefix, xmlns))
> -
>        *p = SysAllocStringLen(NULL, 0);
> -
>    {
> -
>        if (xmldoc_version(This->node.node->doc) == MSXML6)
> -
>            *p = bstr_from_xmlChar(xmlnsURI);
> -
>        else
> -
>            *p = SysAllocStringLen(NULL, 0);
> -
>    }
>     else if (ns->href)
>         *p = bstr_from_xmlChar(ns->href);
> }

This could be WCHAR constant to avoid conversion, defined in the method 
body, if it's not used anywhere else.