2006/6/11, Eric Pouech eric.pouech@wanadoo.fr:
Peter Åstrand wrote:
On Sat, 10 Jun 2006, Eric Pouech wrote:
ChangeLog: winmm: Add support for "open new" commands.
looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias)
I'm not sure I understand what you mean, how is the alias related to the verification of a correct device name?
it's not. but I don't think a command like 'open new type waveaudio' shall work (as the name of the MCI device would be new in that case, which is a reserved keyword). In other words, I think that 'open new' should fail if no alias is given.
for the sake of completeness, I tested it on Windows: mciSendString("open new type wavedaudio", ...) fails with the error MCIERR_NEW_REQUIRES_ALIAS. This must be properly handled before submission into Wine.
A+