Re: [PATCH v3 4/8] comctl32/listbox: Make SetCount fail if LBS_NODATA is not set

[Nikolay Sivov]

On 11/8/18 2:39 PM, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu
>
> dlls/comctl32/listbox.c       | 5 ++++-
>   dlls/comctl32/tests/listbox.c | 2 +-
>   2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/comctl32/listbox.c b/dlls/comctl32/listbox.c
> index 2137ef8..0a7c341 100644
> --- a/dlls/comctl32/listbox.c
> +++ b/dlls/comctl32/listbox.c
> @@ -1752,7 +1752,7 @@ static LRESULT LISTBOX_SetCount( LB_DESCR *descr, INT count )
>   {
>       LRESULT ret;
> - if (HAS_STRINGS(descr))
> - if (!(descr->style & LBS_NODATA))

I think HAS_STRINGS should consider LBS_NODATA instead.