Re: [PATCH 3/4] winmm/tests: Add more MIDI System Exclusive message tests.

[Akihiro Sagawa]

On Tue, 3 Apr 2018 13:21:49 -0500, Andrew Eikum wrote:
> On Sun, Apr 01, 2018 at 11:43:38PM +0900, Akihiro Sagawa wrote:

(snip)
> > -
> >    /* Note On (FIXME: we shouldn't hear this voice due to volume settings) */
> > -
> >    e = (MIDIEVENT *)p;
> > -
> >    e->dwEvent = MEVT_F_SHORT | 0x6F4593; /* note #69 */
> > -
> >    p += sizeof(MIDISHORTEVENT);
> > -
> >    /* Note Off */
> > -
> >    e = (MIDIEVENT *)p;
> > -
> >    e->dwDeltaTime = 400;
>
> I noticed in patch 1, you added a Sleep(400) to let the note play. Is
> that not needed here?

In MIDI Stream case, multimedia API maintains event timers.
dwDeltaTime member is used for that.
> Also, could the duration be shortened, so the tests run more quickly?

Sure. I reduced duration time from 400ms to 200ms and explicitly set time
division value. See v2 patch for details.

Thanks for reviewing,
Akihiro Sagawa