Re: advpack: Forward ExecuteCabA to its unicode counterpart

[Robert Shearman]

James Hawkins wrote:
> @@ -86,6 +87,43 @@ HRESULT WINAPI DoInfInstall(const SETUPC
>
> /***********************************************************************
> -
>         ExecuteCabA    (ADVPACK.@)
> -
> -
> -
> - See ExecuteCabW.
> - */
>
> +HRESULT WINAPI ExecuteCabA(HWND hwnd, CABINFOA* pCab, LPVOID pReserved)
> +{
> - UNICODE_STRING cab, inf, section;
> - CABINFOW cabinfo;
> - HRESULT hr;
> -
> - TRACE("(%p, %p, %p)\n", hwnd, pCab, pReserved);
> -
> - if (!pCab)
> -
>    return E_INVALIDARG;
> -
> - RtlCreateUnicodeStringFromAsciiz(&cab, pCab->pszCab);

pCab->pszCab can be NULL, right? I don't think 
RtlCreateUnicodeStringFromAsciiz handles that case in the way you expect.