Re: [PATCH] [shell32] Implement SHRunControlPanel using ShellExecute

[Nikolay Sivov]

On 26.02.2015 17:01, Robert Naumann wrote:
> dlls/shell32/shellord.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c
> index 914dc5a..9ea3d62 100644
> --- a/dlls/shell32/shellord.c
> +++ b/dlls/shell32/shellord.c
> @@ -1129,8 +1129,10 @@ HRESULT WINAPI SHWinHelp (DWORD v, DWORD w, DWORD x, DWORD z)
>    */
>   BOOL WINAPI SHRunControlPanel (LPCWSTR commandLine, HWND parent)
>   {
> - FIXME("(%s, %p): stub\n", debugstr_w(commandLine), parent);
> - return FALSE;
> - if((int)ShellExecute(parent,NULL,commandLine,NULL,NULL,SW_NORMAL)>32)
> -
>    return TRUE;
> - else
> -
>    return FALSE;
> }

Why 32? Also please don't remove tracing line.