Re: [PATCH] xaudio2_7: Trace FAudio version being used

[Andrew Eikum]

This adds a hard dependency on FAudio >= 19.05. Even Debian meets this
requirement (the oldest they ship is 19.07[1]), so maybe this is OK,
but I'm not sure if we want to add that requirement this late into
code freeze. I think my preference would be to defer this patch.

[1] https://packages.debian.org/search?keywords=faudio

Andrew

On Tue, Jan 14, 2020 at 04:49:42AM +0000, Alistair Leslie-Hughes wrote:
> Signed-off-by: Alistair Leslie-Hughes
>
> dlls/xaudio2_7/xaudio_dll.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c
> index a87e0124d3..ae18a72e2b 100644
> --- a/dlls/xaudio2_7/xaudio_dll.c
> +++ b/dlls/xaudio2_7/xaudio_dll.c
> @@ -90,6 +90,8 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD reason, void *pReserved)
>      case DLL_PROCESS_ATTACH:
>          instance = hinstDLL;
>          DisableThreadLibraryCalls( hinstDLL );
> -
> -
>    TRACE("Using FAudio version %d\n", FAudioLinkedVersion() );
>    break;
> }
>    return TRUE;
>
> -- 
> 2.17.1