Re: [PATCH] include: Check whether the ms_abi attribute is supported on aarch64

[Chip Davis]

December 20, 2020 4:39 PM, "Martin Storsjo"  wrote:
> diff --git a/include/msvcrt/corecrt.h b/include/msvcrt/corecrt.h
> index 4d11f68be0d..a66f43877ac 100644
> --- a/include/msvcrt/corecrt.h
> +++ b/include/msvcrt/corecrt.h
> @@ -81,7 +81,7 @@
>  #  endif
>  # elif defined(__arm__) && defined (__GNUC__) && !defined(__SOFTFP__)
>  #   define __stdcall __attribute__((pcs("aapcs-vfp")))
> -# elif defined(__aarch64__) && defined (__GNUC__)
> +# elif defined(__aarch64__) && defined (__GNUC__) && __has_attribute(ms_abi)

Are you sure that every version of GCC that supports __attribute__((ms_abi)) on AArch64 also supports __has_attribute()?

Chip