Re: [RFC PATCH] strmbase: Allow NULL pin_get_media_type() callback in source_Connect().

[Zebediah Figura]

On 5/20/20 9:36 AM, Akihiro Sagawa wrote:
> Hi Zebediah,
>
> I have a question about strmbase. By commit 38f5f364629650cba3ee90f326c2bb4f1c0f19c1,
> you made pin_get_media_type() callback optional. However,
> source_Connect() in strmbase/pin.c still uses base.pin_get_media_type()
> without NULL pointer checks.
>
> Was it done by design or not? If yes, I'll add some workarounds to my
> source (actually testsource_ops in dlls/quartz/tests/mpegsplit.c).
> If not, please feel free to apply this patch.
> Signed-off-by: Akihiro Sagawa
>
> dlls/strmbase/pin.c | 17 ++++++++++-------
>   1 file changed, 10 insertions(+), 7 deletions(-)

Yes, that seems to have been an error on my part. Thanks for catching it!