On 7 Nov 2002, Alexandre Julliard wrote:
packagers shouldn't need any specific patches to configure or makefiles; if they need that either they are doing something wrong, or there is something broken in Wine that should be fixed.
I mostly agree with you, and you'll notice that the FreeBSD port of Wine at
http://www.freebsd.org/cgi/cvsweb.cgi/ports/emulators/wine/files/
has reduced significantly in size ever since I assumed maintainership, but some issues are not so easy, though erhaps we can resolve them together:
--- Make.rules.in.orig Fri Oct 4 06:42:42 2002 +++ Make.rules.in Tue Oct 8 09:46:22 2002 @@ -25,7 +25,7 @@ SHELL = /bin/sh CC = @CC@ CPP = @CPP@ CFLAGS = @CFLAGS@ $(EXTRACFLAGS) -OPTIONS = @OPTIONS@ -D_REENTRANT +OPTIONS = @OPTIONS@ -D_REENTRANT -D_THREAD_SAFE LIBS = @LIBS@ YACC = @YACC@ LEX = @LEX@
Will you accept this if I submit it as a patch or is it wrong? (If so, why?)
--- documentation/samples/config Thu Jan 11 01:57:36 2001 +++ documentation/samples/config Sat Jan 13 15:29:39 2001 @@ -146,7 +146,7 @@ WINE REGISTRY Version 2
[serialports] -"Com1" = "/dev/ttyS0" -"Com2" = "/dev/ttyS1" -"Com3" = "/dev/ttyS2" +"Com1" = "/dev/ttyd0" +"Com2" = "/dev/ttyd1" +"Com3" = "/dev/ttyd2" "Com4" = "/dev/modem"
How shall we deal with this?
--- Makefile.in.orig Fri Aug 2 21:34:21 2002 +++ Makefile.in Mon Aug 5 13:10:16 2002 @@ -91,18 +91,6 @@ install-lib:: $(INSTALLLIBSUBDIRS:%=%/__ install-dev:: $(INSTALLDEVSUBDIRS:%=%/__install__) install-aclocal
install:: install-aclocal - -$(LDCONFIG) - @if test -n "`LANG=C $(LDD) $(bindir)/wine|grep not.found`"; \ - then \ - echo "*************************************************" ; \ - echo "*************************************************" ; \ - echo "The installed Wine libraries will not be found!" ; \ - echo "You can either:" ; \ - echo " Add the line '$(libdir)' to /etc/ld.so.conf" ; \ - echo ' export LD_LIBRARY_PATH=$$LD_LIBRARY_PATH:$(libdir)' ; \ - echo "*************************************************" ; \ - echo "*************************************************" ; \ - fi
FreeBSD does not have /etc/ld.so.conf, so this message is not correct there; in fact, no system I am aware of (except my GNU/Linux boxes) has that file.
(Apart from that, the FreeBSD port system takes care of invoking LDCONFIG by itself, and calling LDCONFIG as above would remove the entire configuration on most installations.)
Gerald