Gabriel Ivăncescu gabrielopcode@gmail.com writes:
On Thu, Sep 27, 2018 at 4:08 PM, Alexandre Julliard julliard@winehq.org wrote:
The basic rule is that you don't make changes unless there's a reason. When things are simply a matter of taste and either way works fine, the existing code should be left alone.
-- Alexandre Julliard julliard@winehq.org
Yes but isn't a reason to possibly re-arrange it, when adding more fields (patch 5/6)? Of course, it changes the overall layout, so it won't just feel like it's built on top of each other, but rather like it fits and belongs better together. i.e. like it was "designed like this from the beginning" which is cleaner than trying to avoid to change existing fields in my opinion.
If it's necessary to make things easier to understand, yes. That doesn't seem to be the case here.
The important resource here is not a few bytes of memory or a couple of CPU cycles, it's developer's time. Making unnecessary changes has a cost in brain cycles, when reviewing the patch, when searching through the history, and when trying to understand why things are done a certain way. Please keep that in mind.