Dmitry Timoshkov dmitry@baikal.ru writes:
Alexandre Julliard julliard@winehq.org wrote:
The tests clearly show that this commit is wrong. If there is an application or a test case which fails because of this, it would be helpful to at least mention it.
It fixes the test for .bss protection, in ntdll:info.c.
I don't see that test failing before that commit or after the revert.
It fails with PE binaries but not Unix ones.
So the test doesn't really exist? Why do you think that a failure you see is a loader thing and not something that happens at run-time? Please add a real test and I'll have a look.
The test requires a PE binary because obviously we can't test PE protections on Unix binaries. That doesn't mean it doesn't exist. Just build a crosstest:
$ wine ntdll_crosstest.exe info.c info.c:1296: Test failed: mbi.Protect is 0x8, expected 0x4