On Fri, Sep 7, 2018 at 12:07 PM, Huw Davies huw@codeweavers.com wrote:
While changing hwndText from a static buffer to a dynamically allocated array is a good plan, it doesn't belong in this patch.
This whole function is a mess anyway. It would probably help to have the WM_KEYUP (or the new WM_KEYDOWN/WM_CHAR) handling done in helper functions.
If I do it in a separate patch before this, I'll have to add code that I'll remove in the very next patch in the series. Is that acceptable?
Helper functions might work, but the problem is I wouldn't be able to share code paths as easily between WM_KEYDOWN and WM_CHAR, like it is now. I think they may complicate some things in such areas.
Also, that would require even more changes to the code. I tried to keep even the indentation the same so that the patch is smaller, since it's already too big.