On Tue, Jun 05, 2001 at 12:18:00AM -0700, Francois Gouget wrote:
On Tue, 5 Jun 2001, Bang Jun-Young wrote:
- Configure message is wrong: checking whether we can build a Linux dll... yes I see this even on FreeBSD and NetBSD. :( It's not a Linux dll, but an FreeBSD/NetBSD dll.
Maybe this message should be changed, yes. But I don't think you should put a `uname` there.
Could you explain me a bit further why we shouldn't do that?
- Linux/FreeBSD/NetBSD running on x86 are all based on ELF, so replacing 'Linux' with 'ELF' would be more appropriate. The problem is, however, they have slightly different linker flags for building shared libraries. For example, giving -Bsymbolic when compiling sources on NetBSD causes an error even though compiler/linker toolchain is almost same as one used in Linux. It's due to different startup code, but unfortunately, I have no idea how to detect it during configure process without help from uname.
If it gives an error then it should be easy to detect with autoconf: Just use the flags that cause the command to fail. If it fails then we must use other flags. Otherwise these are the ones to use. What kind of error is it btw?
programs/winetest.c couldn't find where the global variable environ is. It could be easily fixed by adding 'extern char **environ' to the beginning of the file without touching ld flags, but I thought it would be better if I was able to do the same without touching sources instead.
- IMHO, my modification is more readable than existing code.
Why don't you show us the new code, or an outline thereof?
Oh, I'm sorry to forget that. *) Here it is.
Jun-Young