Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent.

[Joris Huizer]

Hello Dmitry Timoshkov,

I noticed a small issue in your patch:
> -    ret = DestroyWindow(parent);
> -    ok( ret, "DestroyWindow() error %d\n",
> GetLastError());
> +    ok(DestroyWindow(parent), "DestroyWindow()
> error %d\n", GetLastError());

Please don't merge the call with the ok() statement; the GetLastError() call might be executed before the function to be tested, thus giving the old value. (There has been some cleaning up for this issue recently)

The same goes for a few tests you added:
> +    SetLastError(0xdeadbeef);
> +    ok(SetForegroundWindow(popup),
> "SetForegroundWindow() error %d\n", GetLastError());
> +    SetLastError(0xdeadbeef);
> +todo_wine
> +    ok(SetForegroundWindow(popup),
> "SetForegroundWindow() error %d\n", GetLastError());
> -
>
> +    SetLastError(0xdeadbeef);
> +    ok(DestroyWindow(parent), "DestroyWindow()
> error %d\n", GetLastError());
> -

HTH,
Joris