On 11/05/2022 01.05, Nikolay Sivov wrote:
When looking at this series, I found more disturbing thing in existing code - static BOOL bGroupSelect = TRUE; in mouse selection helper.
Not only it's global, but it also does not work correctly as far as I can tell. I tried with LVS_ICON case, and when alternating ctrl+click, ctrl+shift+click, selected pattern does not match what I see on Windows.
Do you think you can look into that before fixing owner-data case?
There are seemingly quite a few things broken in list views, hence everything marked as todo?
I sadly do not believe I have spare time to tinker with the LVS_ICON case or similar, I personally have never used those modes of operation. Just a fellow developer trying to fix a downstream issue by improving the upstream library.