Hi John, On Tue, Apr 16, 2019 at 5:59 AM John Thomson < git@johnthomson.fastmail.com.au> wrote:
"SHCreateDirectoryExW returned %d. Expected %d",
I missed a newline at the end of one of the ok strings
Should I add this newline, squash both of my commits, and submit a new
version of this patch?
Any other hints or comments?
Yes, you need to send a new try. And you will need to send your fixing and tests in one patch, or at least in a same series.
You can check the status of your patches in https://source.winehq.org/patches/ .
https://wiki.winehq.org/Submitting_Patches