Hi Alex,
On 08/04/15 16:39, Alex Henrie wrote:
2015-08-04 8:36 GMT-06:00 Alex Henrie alexhenrie24@gmail.com:
Hi,
Could I get some feedback on the following changes before I submit them to wine-patches?
Shoot, I just sent these to wine-patches by accident instead of wine-devel. Feedback would still be appreciated.
First two patches are fine on wine-patches. They look good to me.
The third patch needs more work. It would be nice to have event helper functions more generic as in if we want to use them for yet another element type, we wouldn't need to add another argument. Maybe callers should call appropriate GetHref and GetTarget and pass strings to the helper?
Also, it would be nice to have a trivial test case for area element. See dom.c for an example. Just a call to test_elem_type for an area element should be enough for the stub.
Thanks, Jacek