On Wed, Jun 11, 2008 at 5:59 PM, Zachary Goldberg zgs@seas.upenn.edu wrote:
Proposal: Revert the commit referenced in bug #11584 before this Friday, so it can be tested in rc5. I think the weight of the following is greater than breaking a test (making the test a todo for now would be a good idea I think). Also, there's no reason to keep the patch reverted post 1.0 as devs continue to make progress towards a proper solution.
First, the list of applications thought to be broken by the patch as documented in bugzilla (more may exist):
Call of Duty 4 (11584 itself) Psychonauts (11630) Fifa 2006 world Supreme Commander Oblivion (Maybe?)
So why not wait for 1.0.1? Of the remaining 1.0 bugs this is the biggest one known to have broken a large number of *popular* games. In addition as soon as 1.0 is released the floodgates will open for patches and wine may not be stable enough to release again for a few weeks. This leaves all of the gamers who downloaded 1.0 [for these games] out in the cold without a package which includes a fix and a sour taste in their mouths.
Steve D. has been making good progress towards finding a proper fix for this bug; however by no means should we put pressure on him to have this bug fixed by Friday. Thus I propose we revert the initial commit for now, test it during rc5 to make sure things work again, and then allow Steve to properly fix the bug post 1.0.
-Zach
+1
Stefan/Roderick, any idea how long a patch would take to write to either fix this properly or revert the broken parts of the patch and adjust the tests accordingly?