Hi Stefan,
Thanks for your review! I have submitted a new patch.
2015-03-23 23:34 GMT+08:00 Stefan Dösinger stefandoesinger@gmail.com:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
On 03/23/15 16:16, KaiPeng Zeng wrote:
I had planned to submit test first and make "Implement findstr.exe for Wine" as my GSoC proposal. Do you think it is ok to as a GSoC proposal? Can you give me some suggestions?
Adding tests before adding an implementation is a reasonable idea in general.
On a quick glance at the findstr.exe help output it seems like this is a doable project, but I cannot say too much without a real gsoc application. Do you know a Windows application that requires an implementation of this tool?
Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJVEDJ4AAoJEN0/YqbEcdMwrx4P/11vN9jhDaox/TeZUonzIYnr qMeaPmd1ED1KnC+rNsN8lDFRgzHNps5UcwtpFf4BoHowd5ylVGeKs/5T320PX/EA JVgGGPYnDTxF8ZnM/stFt2sYvlP43uGwwd+ttDCXYinwEzByR6ggHiLQIoADDL0a QLj0PFeYE1tZs6cVCoUGuVJBV234iJk1VXdasqOkw54w3ybtfbkc0n/EQjWsqDaU sOnO4BHpzF7/2f+NXL7E0VG5OvyT07ZNM8MSrCoalJLijak/L0Ieu+3JTVGt+s2D +M9mMpKEl3Xparcs1R4lYYK262BWDOYS9OC2m2Cw+chuBKk9oRBRn3ekBgpXQbsv uRw+E1S4XqWEYGDfy7EEx+K4UX+ZMDLB0e3kmkBph4k05Ogq9ZxiIFZc1k/fPorp oPitpCEdEyK/sy5zb3kR7L8K+yI4PSOzLA0X1InsDujDVW20dQ5Vp8B91CHPEwzY 0qigYwU4L7JTEbXqkWR7aYV4EY4ZVh0A85/2b1ZRH1fpwZI35xoTqIQGg89F1XUv qyP8i6vCGLcpBsHfMsx9TY0Tod31e0fXh5UDlPT7JuGhkYLVBLAsG5oJCuOgQWvg llr2PHRCs1PaRqLbshCR8NTK2cks92hN5MjBZCa34F13p6yshW+hxJfA/+vvnswF 4y8SYkHYl9f6ysWjSHna =0tiD -----END PGP SIGNATURE-----