Re: [PATCH] mshtml: Implement HTMLAnchorElement_get_pathname().

[Jacek Caban]

Hi Hans,

On 11/2/21 3:27 PM, Hans Leidekker wrote:
> - if(path[0] == '/') {
> -
>    BSTR str = SysAllocString(path + 1);
> -
>    SysFreeString(path);
> -
>    if (!str)
> -
>        return E_OUTOFMEMORY;
> -
>    *p = str;
> - }

We had problems with this in the past already, see e33ce7c5385 for 
example. Spec says that we should include leading slash in the result. 
IE does that in some cases, but doesn't in other cases. It's not clear 
to me what exactly triggers broken behaviour, but your tests happen to 
fall into this. I attached tests that check for proper results. I'd 
rather start with implement proper behaviour (which is more likely to be 
expected by scripts) and try to implement 'broken' behaviour only if we 
have a strong reason.

Also, if possible, using Gecko's GetPathname would be preferable (unless 
it doesn't do what we need for some reason).

Thanks,

Jacek