Gregg Mattinson gm138242@scot.canada.sun.com writes:
So, my question is, why does the $(MODULE).so rule in Makedll.rules.in contain $(LDDLLFLAGS)? Until I submitted this patch, that variable was not defined in the makefiles for the .dlls, and the dlls appeared to work fine. Now that this flag is defined, the .dlls don't work, but the tests do work. Should LDDLLFLAGS be removed from the $(MODULE).so rule? What is LDDLLFLAGS defined to on Linux? I only have a Solaris box here to test on, so my insight into the problem is limited.
The idea is that all dlls should be linked with LDDLLFLAGS; however only dlls that are properly separated can use it at this point, which is why LDDLLFLAGS is not defined in Makedll.rules, only in the individual makefiles of the dlls that have to use it. This is why your patch breaks for non-separated dlls. I have committed a different fix that I believe should work for you too.