On 12/26/18 19:26, Michael Stefaniuc wrote:
On 12/26/18 12:21 PM, Gabriel Ivăncescu wrote:
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com
There shouldn't be a reason they aren't there like the rest, since they're very simple functions.
Well, there is a reason why I didn't include CopyRect(); it makes no sense. A straight assignment should be used instead, especially as most of the time the arguments are known to not be NULL. There aren't many CopyRect()s left in the code.
PtInRect() I probably didn't add because I didn't replace any open coded variants of that.
bye michael
Yeah, I didn't look at the usage of them, it just doesn't feel right for them to not be complete, even if they are probably not used, feels a bit disorganized. ;-)
There are many PtInRect in the code, though, so I think that one at least has some merit.