Re: [PATCH 2/3] amstream: Implement MediaStreamFilter::EndOfStream.

[Anton Baskanov]

On суббота, 10 апреля 2021 г. 23:35:53 +07 you wrote:
> Sorry for not noticing this before, but...
>
> On 4/9/21 2:02 PM, Anton Baskanov wrote:
> > @@ -275,6 +292,13 @@ static void set_state(struct filter *filter,
> > FILTER_STATE state)> 
> >           for (i = 0; i < filter->nb_streams; ++i)
> >           IAMMediaStream_SetState(filter->streams[i], state);
> >
> >       filter->state = state;
> >
> > -
> > -
> >    if (state == State_Stopped)
> > -
> >        filter->eos_count = 0;
> > -
> > -
> >    if (state == State_Running && filter->seekable_stream
> > -
> >            && filter->eos_count == (LONG)filter->nb_streams)
> > -
> >        send_ec_complete(filter);
> >
> > }
> >
> > }
>
> Is there a reason not to put these in filter_Stop() and filter_Run()
> respectively?

There is no particular reason. And yeah, putting these in filter_Stop() and 
filter_Run() probably makes more sense. Fixed in v3.