Re: [PATCH vkd3d 03/12] vkd3d-shader/hlsl: Introduce hlsl_free_deref().

[Giovanni Mascellani]

Hi,

Il 01/07/22 23:24, Francisco Casas ha scritto:
> +void hlsl_free_deref(struct hlsl_deref *deref)
> +{
> - hlsl_src_remove(&deref->offset);
>
> +}
> -

Again, mostly a nitpick, but personally when a function is called "free" 
and receives a pointer, I assume that it will free the pointer itself 
(after perhaps doing cleanup). Here there is the cleanup, but the 
pointer is not freed, so I would rename to "hlsl_unlink_deref", for 
example. Not sure if others agree with my sentiment.

Giovanni.