Re: [PATCH vkd3d v2 07/10] vkd3d-shader/hlsl: Add helpers for binary arithmetic operations.

[Matteo Bruni]

On Thu, Oct 21, 2021 at 4:58 PM Giovanni Mascellani
 wrote:
> Hi,
>
> Il 21/10/21 16:21, Matteo Bruni ha scritto:
> > Technically this isn't quite the case anymore, add_expr() is still
> > there unchanged after this patch. Some rewording might be in order.
>
> My reasoning here is that with this patch the casting logic in
> add_expr() is not doing anything any more, because the caller already
> feeds add_expr() arguments of the same type. So even if add_expr()
> wasn't touched, the logic has moved. I wasn't sure of how to say this
> without getting into a uselessly long sentence.

I guess it might just be a matter of replacing "moves" with "copies"
or "starts moving". BTW, I think "logic" is uncountable.