Re: [4/20] DDraw: Get rid of FVFs

[Stefan Dösinger]

Am Mittwoch 25 April 2007 09:02 schrieb H. Verbeet:
> On 24/04/07, Stefan Dösinger  wrote:
> > - hr =
> >
> > IWineD3DDevice_CreateVertexDeclarationFromFVF(This->wineD3DDevice, +     
> >                                                  &pDecl,
> > -
> >                                                   (IUnknown *)
> >
> > ICOM_INTERFACE(This, IDirectDraw7), +                                    
> >                   fvf);
>
> Is this right? Passing the IDirectDrawImpl as parent looks a bit
> questionable.

Well, I don't pass the impl, I pass the IDirectDraw7 interface. Of course I 
could create an additional IParent interface, but I'd have to digg it out 
later when destroying the declaration. As long as WineD3D doesn't destroy the 
parent behind my back it is ok. It does not do at the moment, and when we 
change WineD3D from that regard we'll have to adjust ddraw anyway, even if I 
passed a seperate IParent.