On Tue, Jun 24, 2008 at 4:55 PM, Austin English austinenglish@gmail.com wrote:
On Tue, Jun 24, 2008 at 3:55 PM, James Hawkins truiken@gmail.com wrote:
On Tue, Jun 24, 2008 at 3:47 PM, Austin English austinenglish@gmail.com wrote:
Changes like these are so simple that you really should go the extra 5 feet and write simple tests for them.
-- James Hawkins
I have little C/programming experience. I was simply taking the patch mentioned in bug 2642 http://bugs.winehq.org/show_bug.cgi?id=2642, rediffing it against HEAD and submitting it. Looking at the function/MSDN/other testcases, it shouldn't be too rough to write one, I'll see if I can't hack one together.
-Austin
I tried hacking a bit of a testcase together, but my lack of programming skills has led me to a dead end. If someone wants to pick it up from here, or send comments on what's wrong, it's attached. Currently, fails to compile:
austin@SERVER1:~/wine-git/dlls/rasapi32/tests$ make crosstest i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o rasapi.cross.o rasapi.c rasapi.c:1: warning: -fPIC ignored for target (all code is position independent) rasapi.c: In function `test_rasenum': rasapi.c:36: error: syntax error before '=' token rasapi.c:38: error: syntax error before "LPRASDEVINFOA" rasapi.c:39: warning: implicit declaration of function `ok' rasapi.c:42: error: syntax error before "LPDWORD" rasapi.c:34: warning: unused variable `i' rasapi.c: At top level: rasapi.c:48: warning: return type defaults to `int' make: *** [rasapi.cross.o] Error 1