On 2/22/22 12:07, Rémi Bernon wrote:
I'm not sure which one is right, but starting the bin before appending the elements, and in a later patch getting the elements pads, linking them with ours and activating them, causes the pipeline to fail to run.
Starting the bin only after everything is setup, like it was done in the previous version worked.
Hmm, I was under the impression it's legal to add an element to an already running bin; GStreamer certainly has code to handle that case. What does "fail to run" mean in this case?
Also, in a later patch and for H264 we will want to modify sink_caps to remove frame size information, I was doing it in this switch but that won't work if it's below my_sink creation.
Since it doesn't really matter I suppose I'll send a v5 to rearrange things...