On 07/07/2014 03:38 PM, Joris van der Wel wrote:
I dislike duplicating code... An alternative would be to put the entire function in a header file, I've seen examples of other functions that are placed in one, in wine. This would introduce around 70 lines to some .h file. Perhaps along with the other headers for the server protocol?, NTDLL_create_struct_sd is part of the client to server serialization after all... Or in a header of ntdll?
What do you suggest?
I hate duplicated code too but sometimes you gotta do what you gotta do... Duplicating code is considered the less ugly solution in Wine in a lot of situations.
On Mon, Jul 7, 2014 at 12:13 PM, Alexandre Julliard julliard@winehq.org wrote:
Joris van der Wel joris@jorisvanderwel.com writes:
So should I instead copy paste those 2 functions into kernel32 (with NTDLL renamed to KERNEL32)?
Possibly, though there may be better ways to do that.
bye michael