Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (try 2)

[Zhenbo Li]

Hi Jacek,

2015-11-13 19:39 GMT+08:00 Jacek Caban :
> Sorry for the delay, I was waiting for wine-devel discussion to come to
> conclusion, but failed to reply when it did. It would be nice to move it
> from pending state, although I'm not sure we can do that before code freeze.
> -
> - hres = IXMLDOMDocument_loadXML(xmldoc, str, &vbool);
> - SysFreeString(str);
> - if(hres != S_OK || vbool != VARIANT_TRUE) {
> -
>    ERR("loadXML failed: %08x\n", hres);
> -
>    IXMLDOMDocument_Release(xmldoc);
> -
>    return hres;
> - }
>
> Note that if loadXML fails, you will return S_FALSE here, which I'm sure is desired. It would be nice to have a test for that.

Yes, but I'm wondering how to test it, as we can find test cases for
IXMLDOMDocument_loadXML in msxml3/tests
> Also discussion with Nikolay convinced me that assert() would be a better way to handle IObjectSafety errors.
>
> Thanks,
> Jacek

Also, I found that there was a hidden bug:
As we will test these urls for responseXML:
    static const char xml_url[] = "http://test.winehq.org/tests/xmltest.xml";
    static const char large_page_url[] =
"http://test.winehq.org/tests/data.php";

char large_page_url is not a valid xml file, but native mshtml.dll can
handle it properly. It shows we can't just past the responseText to
msxml3.dll. I'll check it more carefully it later.