Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

[Chip Davis]

November 25, 2019 6:28 AM, "Alexandre Julliard"  wrote:
> Chip Davis  writes:
> > @@ -494,6 +499,22 @@ NTSTATUS WINAPI DriverEntry( DRIVER_OBJECT *driver, UNICODE_STRING *path )
> > RegCreateKeyExW( HKEY_LOCAL_MACHINE, mounted_devicesW, 0, NULL,
> > REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &mount_key, NULL );
> > - if (!RegCreateKeyExW( HKEY_LOCAL_MACHINE, devicemapW, 0, NULL, REG_OPTION_VOLATILE,
> > - KEY_ALL_ACCESS, NULL, &devicemap_key, NULL ))
> > - {
> > - HKEY hkey;
> > - if (!RegCreateKeyExW( devicemap_key, parallelW, 0, NULL, REG_OPTION_VOLATILE,
> > - KEY_ALL_ACCESS, NULL, &hkey, NULL ))
> > - RegCloseKey( hkey );
> > - if (!RegCreateKeyExW( devicemap_key, serialW, 0, NULL, REG_OPTION_VOLATILE,
> > - KEY_ALL_ACCESS, NULL, &hkey, NULL ))
>
> These are already created by the respective drivers, it doesn't seem
> necessary to do it twice.

Whoops. This change has been sitting in my tree for a long time, before those drivers started doing that. I'll resend without these changes.
> --
> Alexandre Julliard
> [e-mail]

Chip