Jeremy White wrote:
I think in my case the problem is a bit different; I have the library - what I don't have are the development headers. Thus the linking all works, but HAVE_LIBXSLT is not defined, so the transform function ends up as a stub, and goes on to fail.
And I still don't know a right answer.
The attached patch is one approach - skip the tests in this case.
Does this seem like a reasonable approach to folks?
Such checks should be made in runtime and tests should depend only on WinAPI stuff. I'd suggest something like an attached patch.
Jacek
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index bd45a77..b8d53f5 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -3245,8 +3245,12 @@ static void test_testTransforms(void) BSTR bOut;
hr = IXMLDOMDocument_transformNode(doc, pNode, &bOut); - ok(hr == S_OK, "ret %08x\n", hr ); - ok( compareIgnoreReturns( bOut, _bstr_(szTransformOutput)), "Stylesheet output not correct\n"); + if(hr == E_NOTIMPL) { + skip("transformNode returned E_NOTIMPL, assuming libxslt not available\n"); + }else { + ok(hr == S_OK, "ret %08x\n", hr ); + ok( compareIgnoreReturns( bOut, _bstr_(szTransformOutput)), "Stylesheet output not correct\n"); + }
IXMLDOMNode_Release(pNode); }