Re: [PATCH 1/2] d3dx10/tests: Add tests for D3DX10GetImageInfoFromResource{A, W}().

[Matteo Bruni]

On Mon, Nov 9, 2020 at 5:13 AM Ziqing Hui  wrote:
> Signed-off-by: Ziqing Hui
>
> dlls/d3dx10_43/tests/d3dx10.c | 78 +++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)

Both patches look generally good. I have a couple of small comments /
questions though.

+    ret = CopyFileW(current_module_path, resource_module_path, FALSE);
+    if (!ret)
+    {
+        if (winetest_debug > 1)
+            trace("CopyFileW failed, error %u.\n", GetLastError());
+        return NULL;
+    }

Maybe a skip() in place of the debug-level-dependent trace() is more
appropriate?

+    SetFileAttributesW(resource_module_path, FILE_ATTRIBUTE_ARCHIVE);

Is this one necessary? If so, in what case?