Re: [PATCH 5/8] reg: Add wchar/type conversion functions

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Am 2014-11-06 22:17, schrieb Jonathan Vollebregt:
> - {REG_NONE, type_none},

An idea for a future test: Test if REG_NONE does anything useful. That's not a blocker for this patch though.
> +static DWORD wchar_get_type(const WCHAR *type_name)
>  {
> ...
> -
>
> for (i = 0; i < ARRAY_SIZE(type_rels); i++)
> -
>
> {
> -
>    if (!strcmpiW(type_rels[i].name, type_name))
> -
>        return type_rels[i].type;
> -
>
> }
>
> return -1;
>
> }
> ...
>         if (reg_type == -1)

Dmitry shout at me, but ~0u would be better since DWORD is unsigned.

If REG_NONE doesn't do anything useful you could use REG_NONE for this purpose. That's just a suggestion though, ~0u is fine for me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUXLWtAAoJEN0/YqbEcdMwfVEP/Ap54MfEFnTiDeM9g7/ps9Gf
41SSLz0IJLgNf+UZlifdS1jajIL7lYM6jo91skiJXPfu36kdQeGvOEwJJhCmrPH3
lvdDMetjOKj6Zx7eoawYIi1ZhUSavp6ZMeLT0zBjdzHN14fHZHlccVnw/Jmb/Gd6
zq04scw0wRenWHobb69eW6dAQXy1N9bz9o9wavA6wvVKWo+k5EMSfJB+F3wGMJHN
M8/eENJLBbZcpig2Rrlu8xUG1qVHjT01rjmwEJKAl83nj0cfrvWsudm6addZFL/H
mLRjJfvZcLe9qBs8gUNtzgdDNqRCjuRjHHcV7qhn7TV/VsHLr68vuvLmLrbDX/vE
G9x6jbA9C/Ob8L1QyMTeJyE2aCfVklHGuGpiS8NmzLNT974tllWTnXgA9tkeXQNC
xt/hEoHXlTW9o+Dv70XLbdf6Y2Cw6rrDFGRDvUUAjTGPyRG6R8zTv1Jex4KkxJiH
8/cgm552PU2SIoqNneXbQswbJ7OOGwgi64J24YzfD8x2IpT4FaIqpXqZ0dGh00iO
Y/XbA57yA8gi9hRrP2xC8WODHJBctRizhW9JCRKZp4jDb3/gKoK35WWSNY3jlku5
8/fTCv94gHv+K08GH4XdJ+Zm5nSjSLhjCkx0R3KwKuf5ansmPzmSysjEqfjQs8es
RcGjE3c16jM532UVuHa8
=Cjz7
-----END PGP SIGNATURE-----