Re: [PATCH 1/2] dlls/mciwave.c: correctly handle error return status from mmioRead

[Andrew Eikum]

Signed-off-by: Andrew Eikum

On Wed, Mar 30, 2022 at 02:57:38PM +0200, Eric Pouech wrote:
> Signed-off-by: Eric Pouech
>
> Supersedes 230982
>
> dlls/mciwave/mciwave.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/mciwave/mciwave.c b/dlls/mciwave/mciwave.c
> index 1d9abce84a3..3ca884ed6e0 100644
> --- a/dlls/mciwave/mciwave.c
> +++ b/dlls/mciwave/mciwave.c
> @@ -291,7 +291,7 @@ static	DWORD WAVE_mciReadFmt(WINE_MCIWAVE* wmw, const MMCKINFO* pckMainRIFF)
>      if (!pwfx) return MCIERR_OUT_OF_MEMORY;
>  r = mmioRead(wmw->hFile, (HPSTR)pwfx, mmckInfo.cksize);
> - if (r < sizeof(PCMWAVEFORMAT)) {
> - if (r < 0 || r < sizeof(PCMWAVEFORMAT)) {
> HeapFree(GetProcessHeap(), 0, pwfx);
> return MCIERR_INVALID_FILE;
> }