Re: [PATCH v6 2/7] winex11.drv: Initialize GPU registry data.

[Józef Kucia]

On Wed, May 22, 2019 at 11:17 AM Zhiyi Zhang  wrote:
> +static BOOL xinerama_get_gpus( struct x11drv_gpu **new_gpus, int *count )
> +{
> - static const WCHAR wine_gpuW[] = {'W','i','n','e',' ','G','P','U',0};
> - struct x11drv_gpu *gpus;
> -
> - /* Xinerama has no support for GPU, faking one */
> - gpus = heap_calloc( 1, sizeof(*gpus) );
> - if (!gpus)
> -
>    return FALSE;
> -
> - strcpyW( gpus[0].name, wine_gpuW );
> -
> - *new_gpus = gpus;
> - *count = 1;
> -
> - return TRUE;
>
> +}

Is it really required to create fake GPU data? Do you see a path
forward to improve this? In order to match the Windows behavior the
GPU name should be consistent with the name returned by other APIs,
i.e. OpenGL, Vulkan and Direct3D. Ideally, the GPU name should use the
GPU database from wined3d. In the long term, it it might be needed to
move the GPU database outside wined3d.