Re: ok lets try this yet again

[Detlef Riekenberg]

On Do, 2008-06-26 at 14:38 -0400, [e-mail] wrote:

I have no Idea about the touched code, but still some more hints:

You must use your real name
> - WineD3D_PixelFormat *cfgs = This->adapter->cfgs;
> - BOOL exactDepthMatch = FALSE;  /*Changed june 23,08 */
> - PIXELFORMATDESCRIPTOR pfd;     /*Changed june 23,08 */

Why do you never see similar comments in any Open Source Project?
- It's useless in the source
- That and more informations are available in the
  software control system (wine uses git)
> +/* Changed Section June 24,08 */
> -

See Above
> +#if 0
> - if(DepthStencilFormat)
> -
>  {                     
> - getDepthStencilBits(DepthStencilFormat, &depthBits,
>
> &stencilBits);
> - }
>
> +#endif

You add unused sourcecode here. Why?

Another example, what you missed is the indention in Wine: 
The same as in the rest of the File. Default is 4 Space

Please read our Wiki ( http://wiki.winehq.org/Developers ),
before sending patches.

Thanks for helping Wine