13 Nov
2018
13 Nov
'18
11:35 a.m.
On 11/13/18 1:35 PM, Gabriel Ivăncescu wrote:
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com
The test has been updated to deal with the bug. This is clearly broken Windows behavior, because the same 32-bit app returns a different size depending on whether it's ran under WOW64 or natively 32-bit, and only with LB_GETTEXTLEN, which makes no sense at all. So IMO we can choose which one to return here, and size of a pointer simply makes more sense.
I don't think broken() is justified in this case. It's consistent across Windows versions and it's clear how it's triggered.
To some level it doesn't have to make sense and we might consider making it "right", but for now I agree, let's keep a todo while returning consistent data length until we find something that depends on it.