Re: [PATCH 7/7] reg: Clean up reg_delete

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-11-04 21:15, schrieb Jonathan Vollebregt:
> +#define MAX_VALUE_NAME  16384

This is ugly. Why not use lpcMaxValueNameLen from RegQueryInfoKey like
the old code does?
> +#define ERROR_NO_DELETE_ROOTKEY 20003

Ah, here we have the case I raised in patch 3 :-) . This seems like
another error case that advapi32 should be able to handle for you. It
needs tests in reg.exe and advapi32.dll. That's assuming the call is
really supposed to fail - if it succeeds we obviously don't want to
test it and destroy the Windows installation in the process.

Before you test this on the testbot ask fgouget if it is safe to test.
I believe it is since the VMs are restored from read-only snapshots
after every test run.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIbBAEBAgAGBQJUWVxsAAoJEN0/YqbEcdMwQhQP92zeYVEhBb4RXRMhtNsrtU6R
jHPf1hGDtMM484wNhpHv97C/2sQ5RUq4bEAanyNNxdLZEFUJ7vT3LVNcEOmPqVI+
jKR5G9h0tXtqaGlee6fHiMPN6ZfRZjxqCNrNICXcCO13f/eErT+uCRPqLAh5b8YY
Tpo5CsOJgS9tGh2UHBFbRt+ZAa/M0Mu4N/6253140HxQfVVgJ2Q3j3fERJ5TacJI
o26uQpWD0Olu+pv64Ej3eehnGJ5cmHld9wBdbIJjRwvQ8knukzPC6tdhAlZrVoTN
KI3F8r+LIlNQm/VF/E3cQWo/vTXDJsQ5tArOMyQfWvLBzpHOZ3Lye4fF2wwvgVFG
VOfcui1eFmGYR/4f+r/mxbespuyYYBBD+rR2kDnhXgrxqegDIpyfPFN3cQQDSHJD
FVoEb8mb4nxkqckywWw4tDBp7TM0dOJsUKeLIyjmT4sl+LH8YWCuINL0eN7i9AlV
XhK7wjF02vVmXrRiJDycJkAAoS4yxY5tyEPM0Ua/M68cLQ5SJNx1oOXWTJSu5W+b
XNAgc4MCGhtNOsaNE7SQdyETYfoqeStv1BxEb0eTFb+z+uia0lDpxFuytbSkTqWH
xEJJe+bmNnhDqkmOUOz8ShfWoGVmvwGg99t+2XBWmRaveFBHXvJkb2D4XXjfCK7D
CxvCYItQ7xN6Ub9vKMc=
=deiq
-----END PGP SIGNATURE-----