Re: [PATCH] msacm32: Remove redundant not-NULL check (coccinellery)

[Andrew Eikum]

On Thu, Feb 28, 2019 at 12:50:31AM +0100, Michael Stefaniuc wrote:
> diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c
> index e0c5fdd90e..2d7862cb73 100644
> --- a/dlls/msacm32/driver.c
> +++ b/dlls/msacm32/driver.c
> @@ -600,7 +600,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVER phad, HACMDRIVERID hadid, DWORD fdwOpe
>      return MMSYSERR_NOERROR;
>   gotError:
>      WARN("failed: ret = %08x\n", ret);
> - if (pad && !pad->hDrvr)
> - if (!pad->hDrvr)
> HeapFree(MSACM_hHeap, 0, pad);
> return ret;
>
> }

If I'm reading the code right, I think the entire if-statement can be
removed.

Andrew